fix(indexing): bounded-memory yielding pipeline tail + daemon session fixes (#1212) (#1226)

Large-codebase indexing died at the end of "Resolving refs" two ways:
watchdog kills of healthy work (24k-file Java on Windows, #1212 — third
iteration of the #1091/#1122 class) and hard OOMs (Linux kernel scale,
where v1.3.0 could not complete at any watchdog setting). Root causes:
~31 of 37 dynamic-edge synthesis passes ran start-to-finish with no
yield points, several materialized whole-graph snapshots (kotlin
expect/actual opened with getAllNodes() — 2M nodes in one array; the
C fn-pointer pass retained every C file's contents twice plus every
function node), and the post-index WAL checkpoint ran minutes of
synchronous IO on the main thread, killing even a successful index at
the finish line.

The pipeline tail now follows the same discipline as the rest: never
hold O(graph) in the heap, yield everywhere.

- All synthesis passes stream node-kind scans (cursors, not arrays) and
  yield on time-budgeted checkpoints; language gates skip passes whose
  filters a project's file languages provably can't satisfy.
- kotlin expect/actual filters SQL-side; c-fnptr caches are LRU-bounded,
  units stream one file at a time, and the all-functions array +
  write-only id map are gone; spring reads each .java once, not twice.
- runMaintenance moved to a worker thread (own SQLite connection);
  per-file store commits chunk with yields behind a serialized flush
  chain (preserving #1015 file-order determinism); resolver warm-up
  streams the DISTINCT name set; resolution batch-tail and merged-edge
  inserts run in bounded sub-transactions.
- Daemon: fixed a socket-handoff race that could leave a fresh MCP
  session permanently silent (client-hello tail unshifted into a
  flowing stream with zero listeners — the long-standing #662 test
  flake was this real bug); first tool call no longer queues behind
  the query pool's cold start (pool.ready gate).

Validation: Linux kernel (70,129 files, 2.05M nodes, 6.4M edges) fully
indexes in 27m8s on a 2-core/6GB container at default heap + default
watchdog; llvm-project (180k files) completes under 1GB RSS including
kill-and-sync recovery; synthesized-edge and full-graph parity are
byte-identical vs baseline on elasticsearch/redis/vim; the ex-flaky
daemon test passed 25/25 under load. Env-gated diagnostics kept:
CODEGRAPH_SYNTH_TIMINGS pass/phase timings, CODEGRAPH_MCP_DEBUG hop
tracing. Design record: docs/design/main-thread-stall-followup.md.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Colby MchenryandClaude Fable 5 authored and GitHub committed 2026-07-08 23:18:23 -05:00
1 parent 58b6bf5c60
commit a3f90089e8
21 files changed
+1036 -264

No files matched your search

+14 -9
View File
@@ -1399,15 +1399,20 @@ export class ToolHandler {
}
// Read tools: off-load the CPU-heavy dispatch to the worker pool when one
// is attached and healthy (daemon mode), so the daemon's single event loop
// stays free for the MCP transport under concurrent load — otherwise N
// concurrent explores serialize AND starve the transport until the whole
// batch drains (clients then time out). With no pool (direct mode) or a
// degraded one, dispatch runs in-process exactly as before. Either way the
// result flows through the cross-cutting notices — worktree-index mismatch
// (#155) and per-file staleness (#403) — which need the watched MAIN
// instance and so are always applied here, never in the worker.
const result = (this.queryPool && this.queryPool.healthy)
// is attached, healthy, AND has finished its first cold start (daemon
// mode), so the daemon's single event loop stays free for the MCP
// transport under concurrent load — otherwise N concurrent explores
// serialize AND starve the transport until the whole batch drains
// (clients then time out). Before the first worker is warm, calls run
// in-process: a call queued behind a cold start sat invisible until the
// 45s busy backstop — the daemon's first tool call stalling for however
// long a worker spawn takes on a loaded machine (the #662 flake). With
// no pool (direct mode) or a degraded one, dispatch runs in-process
// exactly as before. Either way the result flows through the
// cross-cutting notices — worktree-index mismatch (#155) and per-file
// staleness (#403) — which need the watched MAIN instance and so are
// always applied here, never in the worker.
const result = (this.queryPool && this.queryPool.healthy && this.queryPool.ready)
? await this.queryPool.run(toolName, args)
: await this.executeReadTool(toolName, args);
const withWorktree = this.withWorktreeNotice(result, args.projectPath as string | undefined);